Fix de api-key y mejora del control de versiones

packages/sim-objenious-cron/.env

@@ -5,6 +5,7 @@ OBJ_CLI_ASSERTION=XOc7FtwXD8hUX2SFVX94XSty8wkOmChkwDNF09O_aIxPubMDdFUdCDCB4zpzSI
 OBJ_CLIENT_ID=savefamily_rest_ws
 OBJ_KID=xNfbMiyL1ORXGP8lElhcv8nVaG3EJKye4Lc1YoN3I1E
 OBJ_BASE_URL=https://api-getway.objenious.com/ws
-//OBJ_BASE_URL=https://api-getway.objenious.com/ws/test
+# OBJ_BASE_URL=https://api-getway.objenious.com/ws/test
 
 NOTIFICATION_URL="https://sf-sim-activation.savefamilygps.net/send-activation-mail"
+SIM_ACTIVATION_API_KEY=9e48c4ac-1ab0-4397-b3f3-6c239200dfe6

packages/sim-objenious-cron/config/env/index.ts

@@ -1,5 +1,6 @@
 import { loadEnvFile } from "node:process";
 import path from "node:path";
+import assert from "node:assert";
 
 loadEnvFile(path.join("../../.env")) // Global
 loadEnvFile(path.join("./.env")) // base
@@ -12,9 +13,9 @@ export const env = {
   POSTGRES_HOST: process.env.POSTGRES_HOST,
   POSTGRES_DATABASE: process.env.POSTGRES_DATABASE,
   RABBITMQ_HOST: String(process.env.RABBITMQ_HOST ?? "localhost"),
-  RABBITMQ_USER: String(process.env.RABBITMQ_USER ?? "guest"),
-  RABBITMQ_PASSWORD: String(process.env.RABBITMQ_PASSWORD ?? "guest"),
-  RABBITMQ_EXCHANGE: String(process.env.RABBITMQ_EXCHANGE ?? "/"),
+  RABBITMQ_USER: String(process.env.RABBITMQ_USER),
+  RABBITMQ_PASSWORD: String(process.env.RABBITMQ_PASSWORD),
+  RABBITMQ_EXCHANGE: String(process.env.RABBITMQ_EXCHANGE),
   RABBITMQ_PORT: parseInt(process.env.RABBITMQ_PORT ?? "5672"),
   RABBITMQ_MODULENAME: process.env.MODULENAME,
   RABBITMQ_TTL: process.env.RABBITMQ_TTL,
@@ -30,6 +31,20 @@ export const env = {
   OBJ_KID: String(process.env.OBJ_KID),
   OBJ_BASE_URL: String(process.env.OBJ_BASE_URL),
 
-  NOTIFICATION_URL: String(process.env.NOTIFICATION_URL)
+  NOTIFICATION_URL: String(process.env.NOTIFICATION_URL),
+  SIM_ACTIVATION_API_KEY: String(process.env.SIM_ACTIVATION_API_KEY)
 };
 
+// assert las partes criticas
+assert(env.RABBITMQ_PASSWORD != undefined)
+assert(env.RABBITMQ_USER != undefined)
+assert(env.SIM_ACTIVATION_API_KEY != undefined)
+assert(env.NOTIFICATION_URL != undefined)
+
+if (env.ENVIRONMENT == "production") {
+  assert(env.RABBITMQ_PASSWORD != "guest")
+  assert(env.RABBITMQ_HOST != "localhost")
+}
+
+console.log("CRON: ENV", env)
+

packages/sim-objenious-cron/tasks/background1.ts

@@ -1 +0,0 @@
-export const task = async () => console.log("Background " + new Date().toISOString())

packages/sim-objenious-cron/tasks/check_objenious_request.ts

@@ -236,27 +236,14 @@ export class CheckObjeniousRequests {
   * al servicio que manda los mails
   */
   private async notifyFinalization(operation: ObjeniousOperation & { msisdn: string }) {
-    console.log("Notificada, ", operation)
-
     const req = axios.post(env.NOTIFICATION_URL, {
       ...operation,
       iccids: [operation.iccids]
     }, {
       headers: {
-        "x-apikey-sim-activation": "9e48c4ac-1ab0-4397-b3f3-6c239200dfe6"
+        "x-apikey-sim-activation": env.SIM_ACTIVATION_API_KEY
       }
     })
-    /*
-        const req = this.httpClient.client.post<any>("",
-          { operation: operation },
-          {
-            headers: {
-              "x-apikey-sim-activation": "9e48c4ac-1ab0-4397-b3f3-6c239200dfe6"
-            },
-            baseURL: env.NOTIFICATION_URL
-          }
-    
-        )*/
     await req
   }
 }