From a9589f578b05686b2253733d2b61db45cc5ad713 Mon Sep 17 00:00:00 2001 From: Alvar San Martin Date: Wed, 8 Apr 2026 14:47:57 +0200 Subject: [PATCH] Solucionado cierrre de pool para test --- .../aplication/Sim.controller.test.ts | 7 +++++-- .../sim-consumidor-objenious/aplication/Sim.controller.ts | 1 - .../sim-consumidor-objenious/aplication/Sim.usecases.ts | 2 -- packages/sim-shared/infrastructure/OrderRepository.ts | 5 ++++- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/sim-consumidor-objenious/aplication/Sim.controller.test.ts b/packages/sim-consumidor-objenious/aplication/Sim.controller.test.ts index facacfc..b408723 100644 --- a/packages/sim-consumidor-objenious/aplication/Sim.controller.test.ts +++ b/packages/sim-consumidor-objenious/aplication/Sim.controller.test.ts @@ -4,7 +4,7 @@ import { SimController } from "./Sim.controller.js"; import { EventBus } from "sim-shared/domain/EventBus.port.js"; import { SimUseCases } from "./Sim.usecases.js"; import { ConsumeMessage } from "amqplib"; -import { postgrClient } from "#config/postgreConfig.js"; +import { postgrClient, pgPool } from "#config/postgreConfig.js"; import { httpInstance } from "#config/httpClient.config.js"; import { OrderRepository } from "sim-shared/infrastructure/OrderRepository.js"; import { PauseCancelTaskRepository } from "#adapters/PauseCancelTaskRepository.js"; @@ -56,6 +56,10 @@ describe("SimController Integration Tests (Real UseCases)", () => { } as unknown as ConsumeMessage; }; + after(async () => { + await pgPool.end(); + }); + describe("suspend", () => { it("should call stage_suspend and interact with DB and EventBus", async () => { const iccid = "test-iccid-suspend-" + Date.now(); @@ -72,7 +76,6 @@ describe("SimController Integration Tests (Real UseCases)", () => { const handler = controller.suspend(); await handler(msg); - console.log("Nack: ", eventBusMock.nack.mock.callCount()) // Verify that it reached the stage_suspend logic (which adds to pauseRepository) // We can query the DB or check if ACK was called assert.strictEqual(eventBusMock.ack.mock.callCount(), 1, "Message should be ACKed on success"); diff --git a/packages/sim-consumidor-objenious/aplication/Sim.controller.ts b/packages/sim-consumidor-objenious/aplication/Sim.controller.ts index 92e445c..ca103a0 100644 --- a/packages/sim-consumidor-objenious/aplication/Sim.controller.ts +++ b/packages/sim-consumidor-objenious/aplication/Sim.controller.ts @@ -185,7 +185,6 @@ export class SimController { } const useCaseRes = await this.tryUseCase(msg, this.useCases.stage_suspend(suspendData)) - console.log("res::", useCaseRes) /* const res = await this.tryUseCase(msg, this.useCases.suspend(actionData)) */ diff --git a/packages/sim-consumidor-objenious/aplication/Sim.usecases.ts b/packages/sim-consumidor-objenious/aplication/Sim.usecases.ts index 355aa41..ccb822c 100644 --- a/packages/sim-consumidor-objenious/aplication/Sim.usecases.ts +++ b/packages/sim-consumidor-objenious/aplication/Sim.usecases.ts @@ -285,9 +285,7 @@ export class SimUseCases { } } - console.log("Preactivationdate", suspendData) const activationDate = await this.findActivationDate(suspendData) - console.log("ActivationDate", activationDate) const newTask: CreatePauseCancelTaskDTO = { iccid: iccid[0], diff --git a/packages/sim-shared/infrastructure/OrderRepository.ts b/packages/sim-shared/infrastructure/OrderRepository.ts index b2e965a..757e9e8 100644 --- a/packages/sim-shared/infrastructure/OrderRepository.ts +++ b/packages/sim-shared/infrastructure/OrderRepository.ts @@ -191,6 +191,8 @@ export class OrderRepository { const orderId = currentOrderResult.data?.id if (orderId == undefined) { + await client.query("ROLLBACK") + client.release() return { error: "El order a actualizar no existe " + idType + ": " + idValue } @@ -261,7 +263,6 @@ export class OrderRepository { return updatedOrder } - public async finishOrder(args: FinishOrderDTO) { const client = await this.pgClient.connect(); assert((args.id != undefined) != (args.correlation_id != undefined)) @@ -281,6 +282,8 @@ export class OrderRepository { const orderId = currentOrderResult.data?.id if (orderId == undefined) { + await client.query("ROLLBACK") + client.release() return { error: "El order a actualizar no existe " + idType + ": " + idValue }